Repository navigation
CL-7220 sidecar child runtime cancel/stop calls are fire-and-forget - #606
Merged
TheGreatAxios merged 4 commits intoSep 4, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-7220-sidecar-child-runtime-cancelstop-calls-are-fire-and-forget
branch
2 times, most recently
from
September 3, 2026 22:48
f779591 to
836609d
Compare
Contributor
Author
|
Fixes CL-7220 |
TheGreatAxios
force-pushed
the
cl-7220-sidecar-child-runtime-cancelstop-calls-are-fire-and-forget
branch
from
September 4, 2026 04:52
836609d to
8afbabe
Compare
Contributor
Author
Self-reviewVerdict: the diff correctly routes previously fire-and-forget Findings:
Targeted tests: |
Fire-and-forget handle.cancel and signalChannel.stop calls now catch and report through reportError so a rejected cancel during parent abort cannot become an unhandled rejection.
bun's mock.module replaces @intx/workflow process-wide and cannot be undone for later files in the same bun test process. The cancel-report test's never-resolving runtimeRun then hung the suspendable-child suite. Inject runtimeRun and reportError through SidecarRunChildDeps instead.
signalChannel.stop and spawn-suspendable abort cancel already report through fire-and-forget. Pin that those rejections go through reportError and never become unhandled rejections.
TheGreatAxios
force-pushed
the
cl-7220-sidecar-child-runtime-cancelstop-calls-are-fire-and-forget
branch
from
September 4, 2026 06:20
8afbabe to
66305f5
Compare
TheGreatAxios
changed the base branch from
cl-7221-sidecars-top-level-sigtermsigint-handler-has-no-error
to
main
September 4, 2026 06:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CL-7220 stacked
Fixes CL-7220