Repository navigation
CL-7221 sidecars top-level SIGTERM/SIGINT handler has no error - #605
Merged
TheGreatAxios merged 7 commits intoSep 4, 2026
Merged
TheGreatAxios merged 7 commits into
TheGreatAxios merged 7 commits into
Conversation
orchestrator.close() and anything else that throws during shutdown was an unhandled rejection because the signal listeners used void. The shutdown body now catches, reports, and exits 1, and the listeners attach a rejection handler so nothing can escape.
A drain that throws already exits 1. Pin that the failure is also reported through reportError with operation sidecar.shutdown.
A drain that throws was logged and exited 1 without going through the error sink. Route it through reportError with the same sidecar.shutdown operation as other shutdown faults, then exit 1.
spyOn cannot patch the ESM local binding, so the drain-failed test never observed reportError in CI. Inject report on RunSidecarShutdownArgs the same way hub shutdown does.
Contributor
Author
|
Fixes CL-7221 |
Contributor
Author
Self-reviewFix is sound: the SIGTERM/SIGINT handlers now await a
Targeted tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CL-7221
Fixes CL-7221