Repository navigation
Rename load_skill to skills_load (CL-6455) - #603
Merged
TheGreatAxios merged 1 commit intoSep 4, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
Contributor
Author
|
Fixes CL-6455 |
Contributor
Author
Self-reviewVerdict: the alias is implemented correctly end-to-end (tool definition, run() dispatch, grant minting via
Targeted tests run (all pass):
|
The tools-skills bundle previously aliased skills_load to load_skill, minting two tool definitions -- and therefore two invoke grants -- for one capability. Rework as a straight rename instead: the tool is now skills_load, consistent with skills_list / skills_search, and load_skill no longer exists. One tool, one grant, no fallback. Updates the system prompt that tells models which tool to call (@corbits/skills), the tool-registry-publish grant expectations, and the mocks hallucinated-tool-name fixture -- skills_load is now real, so the plausible-but-nonexistent name a model might still guess is load_skill.
TheGreatAxios
force-pushed
the
cl-6455-load_skill-naminggrant-mismatch-models-call-skills_load-get
branch
from
September 4, 2026 17:53
a7aac14 to
acd781f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CL-6455: models calling
skills_loadgot a grant-denial (tool:.../skills_load/invoke) and retried instead of getting an unknown-tool result or a successful load — the tool was namedload_skill, breaking theskills_list/skills_search/skills_*naming pattern models were following.The first pass at this fixed it by aliasing
skills_loadtoload_skill: a fourth tool definition on the same bundle, and therefore a second invoke grant for one capability. That shape was rejected — one tool should mean one grant, not two names sharing a capability.This rework is a straight rename instead: the tool is
skills_load, consistent withskills_list/skills_search.load_skillno longer exists — no alias, no fallback, per this repo's "no fallbacks" rule. A model still calling the old name now gets the bundle's unknown-tool error result, not a grant denial.Changed:
packages/tools-skills:LOAD_SKILL_TOOL→SKILLS_LOAD_TOOL, definition/description/run-switch updated, alias definition and alias test removed.packages/skills/src/prompt.ts: the<available_skills>system-prompt stanza now tells models to callskills_load.packages/agent-directory,apps/hub/src/skills-mount.ts: comments referencing the old tool name updated.packages/tool-registry-publish/src/describe.test.ts: asserts only@corbits/tools-skills/skills:skills_loadis minted, andload_skillis not.packages/mocks: the hallucinated-tool-name fixture flips —skills_loadis now real, so the plausible-but-nonexistent name a model might still guess isload_skill.Fixes CL-6455