Skip to content

Show agents roster display names, Live status, and catalog model labels (CL-6748) - #602

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-6748-agents-roster-shows-slug-idledeployed-shout-and-raw-model
Sep 4, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-6748-agents-roster-shows-slug-idledeployed-shout-and-raw-model

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

The agents roster still showed the kebab slug under the display name, shouted Running next to a Live status dot, and dumped raw canonical model ids in monospace. Copy now matches settings: name slot is displayName only, status is sentence-case Live/Idle (Badge normal-case, same as skills), and a stored canonical maps through the tenant catalog the same way settings already does (displayName, else the canonical).

An unset model still reads Default — this PR does not rewrite it to the tenant default (CL-6782). Slug stays the URL (definition.name is unchanged). Create-agent panel is untouched (CL-6749).

Fixes CL-6748

The name slot is display name only, status is Live not Running shout,
and the model column maps a canonical id to the catalog displayName.
The name slot is the display name only; status badges are sentence-case
Live/Idle (not Running shout); the model column maps a stored canonical
id through the tenant catalog the same way settings already does.
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Self-review

Verdict: changes match the stated intent (displayName-only name slot, sentence-case Live/Idle/Deployed badges, catalog-mapped model labels) and are internally consistent with the existing settings-page pattern (displayName ?? canonicalName). No defects found; nothing was changed.

  • Catalog model mapping matches settings' own catalogModel.displayName ?? catalogModel.canonicalName reading (agent-detail-page.tsx) — DISMISSED, verified parity, not an invented convention.
  • DEFINITION_STATUS_LABEL covers both AgentDefinition["status"] members (deployed/stopped) — DISMISSED, exhaustive, no default-case risk.
  • Unset model intentionally stays "Default" rather than resolving through the catalog default (CL-6782 scoped out) — DISMISSED, matches PR body and is test-covered.
  • No new catch, as T, or fallback/legacy path introduced by this diff — DISMISSED.

Targeted tests run:

  • bun test test/agents-page.test.tsx — 31 pass, 0 fail (from apps/web)
  • bun run typecheck — clean (from apps/web)

No commits pushed; worktree already matched origin.

@linear-code

linear-code Bot commented Sep 4, 2026

Copy link
Copy Markdown

CL-6748

@TheGreatAxios
TheGreatAxios merged commit c43dad8 into main Sep 4, 2026
7 checks passed
TheGreatAxios added a commit that referenced this pull request Sep 4, 2026
…#612)

Stacked on CL-6748 (PR #602). Changing Settings tenant default must leave existing agents stored Model values unchanged. New agents may still pick up the default at create.

Connections chooseModel PATCHes offering priority only — never agent-definitions. The roster reads stored capabilities.model; unset stays a stable Default, never the live catalog winner. Catalog mapping for a set model still uses displayName from 6748.

Fixes CL-6782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant