Repository navigation
Treat ACL evaluate failure as error, not deny - #601
Merged
TheGreatAxios merged 2 commits intoSep 4, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Evaluate network and 5xx failures currently collapse to denied, so People/Roles/Grants/Credentials vanish as if the principal were unauthorized. These tests pin catch → error, last-known coalesce, and a registry flag that is not an authenticated deny.
A thrown evaluate probe (network, 5xx) is no longer mapped to denied. The registry still withholds gated sections while loading or denied, keeps last-known allow/deny across a failed refetch, and marks a could-not-check state so the nav does not vanish as if unauthorized.
Contributor
Author
Self-reviewVerdict: the ACL evaluate/deny/error split is correctly implemented — deny stays a gate, a thrown probe becomes
Targeted tests run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings nav probes
evaluateto decide whether People, Roles, Grants, and Credentials belong in the list. A network or 5xx failure was mapped todenied, so those sections vanished as if the principal were unauthorized.This adds a distinct
erroraccess state. Authenticated deny (effectother than allow) still withholds gated sections. A thrown probe does not: last-known allow/deny is kept across a failed refetch, and a first-load failure marks a could-not-check state in the Shared Settings group instead of looking like a deny.Fixes CL-6829