Skip to content

Keep Files scope reachable below lg - #598

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-6473-files-scope-toggle-disappears-below-lg-with-no-fallback
Sep 4, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-6473-files-scope-toggle-disappears-below-lg-with-no-fallback

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

The Files scope toggle lived in StageTopBar actions behind hidden lg:flex. Below 1024px it vanished, and because scope is React state (not a URL), there was no way to reach All workbenches.

This keeps the segmented group at lg and puts an overflow menu in the same actions slot below that breakpoint. The clear-selection action stays "Back to files" — no third All control.

Fixes CL-6473

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Self-review

Verdict: the fix is correct and minimal — the segmented group stays at lg, and a lg:hidden overflow menu in the same actions slot restores access to "All workbenches" below that breakpoint, with a regression test guarding it.

  • CONFIRMED-FIXED: none needed — reviewed the diff against AGENTS.md (fallbacks, exactOptionalPropertyTypes, bare catches, as T, product logic in apps/*) and found no defects to fix.
  • DISMISSED: two elements share aria-label="Files scope" (the segmented group and the menu trigger). Checked — they're mutually exclusive via hidden lg:flex / lg:hidden, so only one is ever in the accessibility tree at a given viewport; not a duplicate-label bug.
  • DISMISSED: the menu items don't show a checked/selected indicator for the current scope. Checked against the existing sort MenuItem list in the same bar — same pattern, no indicator there either. Consistent with the file's existing convention, not a regression.

Targeted tests: bun test test/library-page-selection.test.tsx (run from apps/web) — 19 pass, 0 fail. bun run typecheck (apps/web) — clean.

@linear-code

linear-code Bot commented Sep 4, 2026

Copy link
Copy Markdown

CL-6473

The scope toggle currently uses hidden lg:flex, so below 1024px there
is no way to reach All workbenches. Pin that at least one Files-scope
control stays in the document without the hidden class.
The segmented group still lives in the StageTopBar actions slot at lg.
Below that breakpoint it no longer vanishes: an overflow menu in the
same slot keeps All workbenches reachable without a third All control.
@TheGreatAxios
TheGreatAxios force-pushed the cl-6473-files-scope-toggle-disappears-below-lg-with-no-fallback branch from e47cb8d to 3a59005 Compare September 4, 2026 05:33
@TheGreatAxios
TheGreatAxios merged commit 3389a04 into main Sep 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant