Repository navigation
Keep settings Actions cells from clipping under page-fill (CL-7378) - #596
Merged
TheGreatAxios merged 2 commits intoSep 4, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Contributor
Author
Self-reviewVerdict: change is correctly scoped and tested —
Targeted tests run:
|
Roles and People Actions cells must not inherit page-fill nowrap+ellipsis, or system-role notes and Rename/Delete/Remove controls get truncated.
.page-fill td nowrap+ellipsis truncated Roles notes and People Remove controls. Settings-scoped override: Actions cells overflow visible with min-width, no nowrap ellipsis. Agents and other page-fill tables unchanged.
TheGreatAxios
force-pushed
the
cl-7378-settings-actions-column-in-system-roles-table-and-remove
branch
from
September 4, 2026 05:24
5467aba to
9cbc4d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings Roles Actions and People Remove controls were truncated because
.page-filltables setoverflow: hidden; text-overflow: ellipsis; white-space: nowrap. This adds a settings-scoped override so Actions cells stay fully visible, without removingpage-fillfrom Agents or other pages.Fixes CL-7378
Changes
th/tdwithsettings-actions-cell@corbits/settings-uistyles: overflow visible, no nowrap ellipsis,min-widthon those cells and.settings-row-actionstdclass and CSS contractTest plan
bun test test/roles-section.test.tsx test/people-section.test.tsxinpackages/settings-uipage-filltables) still ellipsize long data cells