Skip to content

Keep settings Actions cells from clipping under page-fill (CL-7378) - #596

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-7378-settings-actions-column-in-system-roles-table-and-remove
Sep 4, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-7378-settings-actions-column-in-system-roles-table-and-remove

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

Settings Roles Actions and People Remove controls were truncated because .page-fill tables set overflow: hidden; text-overflow: ellipsis; white-space: nowrap. This adds a settings-scoped override so Actions cells stay fully visible, without removing page-fill from Agents or other pages.

Fixes CL-7378

Changes

  • Mark Roles and People Actions th/td with settings-actions-cell
  • In @corbits/settings-ui styles: overflow visible, no nowrap ellipsis, min-width on those cells and .settings-row-actions
  • Tests assert the Actions td class and CSS contract

Test plan

  • bun test test/roles-section.test.tsx test/people-section.test.tsx in packages/settings-ui
  • Settings → Roles: system-role note and Rename/Delete buttons fully visible
  • Settings → People: Suspend/Remove fully visible
  • Agents (and other page-fill tables) still ellipsize long data cells

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Self-review

Verdict: change is correctly scoped and tested — .settings-actions-cell opts Actions cells out of .page-fill's nowrap+ellipsis without touching Agents or other page-fill tables. No confirmed defects found.

  • CSS specificity of the override — CONFIRMED-FIXED: no, DISMISSED. .settings-shell .settings-actions-cell (0,2,0) beats .page-fill th/td (0,1,1) regardless of @import hoisting order in app.css, so the override reliably wins.
  • Test rigor — DISMISSED. roles-section.test.tsx/people-section.test.tsx assert both the rendered td class and the actual CSS rule body (no overflow: hidden/nowrap/ellipsis, has overflow: visible/min-width), so this is a real red/green contract, not coverage theater.
  • Scope leak / app-level product rule — DISMISSED. Change lives entirely in @corbits/settings-ui; no apps/* edits.
  • settings-row-actions min-width: min-content addition — DISMISSED. Used on a non-table action row too (roles-section.tsx:329); harmless, doesn't change layout since it matches default flex-item sizing.
  • Secrets / fallbacks / exactOptionalPropertyTypes hazards — DISMISSED. None present in the diff.

Targeted tests run:

  • bun test test/roles-section.test.tsx test/people-section.test.tsx (packages/settings-ui) — 17 pass, 0 fail
  • bun run typecheck — clean

@linear-code

linear-code Bot commented Sep 4, 2026

Copy link
Copy Markdown

CL-7378

Roles and People Actions cells must not inherit page-fill nowrap+ellipsis,
or system-role notes and Rename/Delete/Remove controls get truncated.
.page-fill td nowrap+ellipsis truncated Roles notes and People Remove
controls. Settings-scoped override: Actions cells overflow visible with
min-width, no nowrap ellipsis. Agents and other page-fill tables unchanged.
@TheGreatAxios
TheGreatAxios force-pushed the cl-7378-settings-actions-column-in-system-roles-table-and-remove branch from 5467aba to 9cbc4d1 Compare September 4, 2026 05:24
@TheGreatAxios
TheGreatAxios merged commit 216d5b8 into main Sep 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant