Repository navigation
Show catalog load failure as an error, not an empty picker (CL-6831) - #595
Merged
TheGreatAxios merged 3 commits intoSep 4, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
A failed resolved-catalog load currently leaves the picker looking empty. These cases pin an inventory-style error, a disabled select, Retry plus a Settings hop, and copy that is not the empty-ready hint.
The resolved-catalog catch now keeps a message via describeChatError, disables the model select, and offers Retry plus a Shared Settings hop instead of looking like a connected-providers empty state.
getResolvedCatalog throws InferenceSettingsApiError, whose message is the envelope userMessage. describeChatError only handled ChatApiError, so a catalog 500 always fell through to "Couldn't load the models."
Contributor
Author
Self-reviewVerdict: the fix is correct —
Targeted tests (from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A failed resolved-catalog load on the workbench-settings agent model picker used to look like an empty dropdown:
CatalogStateerror had no message, the select stayed enabled, and the empty-ready hint only rendered forkind === "ready". The catch now storesdescribeChatErrorcopy, disables the select, and offers Retry plus a Shared Settings hop. It does not reuse the empty-catalog "No connected providers yet" string.Verification
cd packages/chat-ui && bun test test/agents-section.test.tsx: new catalog-failure cases failed before the implementation (select still enabled), then 23 pass, 0 fail (exit 0) after.cd packages/chat-ui && bun test test/agents-section.test.tsx src/workbench-settings/agents-section.test.ts: 30 pass, 0 fail (exit 0).bun run typecheck: exit 0.bun run lint: prettier clean; eslint 0 errors / 10 pre-existing warnings.bunx eslint --cache packages/chat-ui/src/workbench-settings/agents-section.tsx packages/chat-ui/src/strings.ts packages/chat-ui/test/agents-section.test.tsx: exit 0.bun run check/bun run testreachscripts/db-setup.test.tsand fail withPostgresError: password authentication failed for user "thegreataxios"(pre-existing localDATABASE_URL, unrelated).Fixes CL-6831