Repository navigation
Dismiss canvas when leaving a rail surface (CL-6819) - #593
Merged
TheGreatAxios merged 2 commits intoSep 4, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Contributor
Author
Self-reviewVerdict: implementation is correct and well-tested — the route-prefix comparison correctly distinguishes a rail leave from nested detail/query-only changes, and the new suite covers all four canvas kinds plus the compact-layout resurrection case. No changes made.
Targeted tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving Routines (or any other rail surface) via in-app nav now closes the canvas column. The create/edit routine sheet, profile card, and artifact pane all dismiss when the first path segment changes, so a compact layout that hid the column cannot resurrect it after returning to expanded.
Nested detail (
/routines→/routines/:id) and query-only changes share a prefix and keep the pane.Fixes CL-6819