Repository navigation
Isolate run-all default-concurrency tests from ambient env - #591
Merged
TheGreatAxios merged 1 commit intoSep 4, 2026
Merged
Conversation
Contributor
Author
|
Fixes CL-7240 |
Contributor
Author
Self-reviewVerdict: minimal, correctly targeted fix —
Targeted tests run:
|
The default sequential probe spread process.env into the child, so WORKBENCH_CHECK_CONCURRENCY set by the parent gate made peakOverlap == 1 fail. Override tests already inject the var; the default path now clears it unless a test sets it.
TheGreatAxios
force-pushed
the
cl-7240-stop-run-alls-own-test-from-breaking-under
branch
from
September 4, 2026 05:07
094cc78 to
d77304f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/run-all.test.tsrunProbespreadprocess.envinto the child, so the default-sequential assertion (peakOverlap == 1) failed when the parent hadWORKBENCH_CHECK_CONCURRENCYset (for example while running the gate itself). Tests that intend an override already inject the var; the default path now clears it unless a test sets it. A new test sets the ambient var and still expects sequential default.CL-7240
Test plan
bun test scripts/run-all.test.ts(15 pass, including the new ambient-env isolation test and existing override tests)WORKBENCH_CHECK_CONCURRENCY=4made the new test fail withpeakOverlap4 vs 1runProbestopped inheriting the var unlessextraEnvsets itFixes CL-7240