Repository navigation
Isolate git fixture tests in temp repos (CL-7372) - #575
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-7372-fixture-guard
branch
from
September 2, 2026 15:49
c0a57d7 to
1930fb4
Compare
TheGreatAxios
force-pushed
the
cl-7372-fixture-guard
branch
from
September 2, 2026 15:58
1930fb4 to
384f5e6
Compare
TheGreatAxios
marked this pull request as ready for review
September 2, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every git-fixture test in apps/hub, packages/hub-client, and packages/tool-registry-publish now creates its fixture repo via mkdtemp, runs git with cwd set to it and GIT_DIR/GIT_WORK_TREE/GIT_INDEX_FILE unset, and is guarded by a check that throws if the fixture path resolves inside this repository's own work tree. apps/hub's two duplicated scratch-dir/git helpers are consolidated into apps/hub/test/git-fixture.ts.
Resolves CL-7372