Repository navigation
Improve chat typography readability (CL-7397) - #572
Merged
TheGreatAxios merged 3 commits intoSep 4, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Bumps .chat-bubble-text and .chat-composer-input to an exact 16px / 500 weight; scope is tightly limited to those two rules and CI is green (840 chat-ui tests, full bun run check).
Must fix
None.
Consider
- Both changed rules hardcode
16pxandfont-weight: 500as literals.react-ui's theme already exposes--text-base: 1rem(16px) and--font-weight-medium: 500(seeapps/web/dist/assets/react-ui-*.css) — using those tokens instead of raw literals would keep this in line with DESIGN.md's "never hardcode... add the token to react-ui if it doesn't exist" posture, even though that line is written about color specifically. Minor, since the surrounding file is already raw-rem throughout. 16px(not1rem) is a deliberate choice per the PR body to guarantee no mobile Safari input-zoom regardless of root font-size — that's a reasonable call for the composer, but worth confirming it's still fine for.chat-bubble-text, which isn't a form control and has no zoom-avoidance requirement;1remwould have matched the rest of the file's unit convention there without changing the rendered size.- No screenshot/before-after image is attached to the PR body itself (it says the comparison lives on the linked issue, CL-548) — for a pure typography/readability change, having the before/after in the PR too would make it reviewable without cross-referencing Linear.
Verified
- Diff is minimal and scoped to
packages/chat-ui/src/styles.css(message bubble text + composer input), no unrelated churn. - Weight 500 is actually loaded for Red Hat Display (
apps/web/index.htmlrequestsRed+Hat+Display:ital,wght@0,400;0,500;...), so this isn't a synthesized/faux-bold weight. - Message metadata (
.chat-bubble-senderat 0.875rem/640) and the 72ch measure are untouched, so sender/timestamp hierarchy and reading width are preserved as claimed. - CI (build-test, db-suites, e2e, isolation, lint, structural, typecheck) all pass on this PR.
Contributor
Author
|
Addressed the review suggestions:
Validation: 843 chat UI tests passed, the production web bundle rebuilt, and the full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before / after
Before
After
Impact
Validation
cd packages/chat-ui && bun test— 843 passed, 0 failed.bun run check— passed. DB-gated suites emitted their expected local skip banners becauseDATABASE_URLis unset; CI runs those in PostgreSQL jobs.Closes #548
Fixes CL-7397