Repository navigation
Redesign Plugins gallery with chip filters and a two-column catalog (CL-7291) - #571
Merged
TheGreatAxios merged 8 commits intoSep 6, 2026
Conversation
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Solid consolidation of the two catalogs and the filter/search intersection is well tested. One real bug found via code inspection below; a couple of things worth tightening before this comes out of draft.
Must fix (before ready for review)
- Duplicate
aria-label="Filter plugins"on the Plugins tab.plugins-page.tsxpasseslabel: "Filter plugins"toStageSearch(the top-bar magnifier —button[aria-label="Filter plugins"]/input[aria-label="Filter plugins"]), andPluginFilterBarinplugins-gallery.tsxrendersrole="group" aria-label="Filter plugins"for the new chip row. Both are live on the same page at once, so two functionally different controls (the per-page search magnifier vs. the category/status chip group) share one accessible name — ambiguous for screen readers and for anything that queries by that label (the new walkthrough step's ownbutton[aria-label="Filter plugins"]/input[aria-label="Filter plugins"]selectors only work because they happen to land on the magnifier'sbutton/input, not the chip group'sdiv). Give the chip group its own name, e.g.aria-label="Filter by category"or similar.
Consider
- The chip row (
PluginFilterBar) is hand-rolled with new CSS (.plugins-filter-bar,.plugins-filter-chip, pill radius,aria-pressedtoggle buttons) rather than an existing react-ui primitive. Tokens are used correctly throughout, but worth a quick check against react-ui for a chip/segmented-filter component before this ships, per the "consume it from react-ui instead of reimplementing" rule in DESIGN.md's header. - Dropping the old five-way category taxonomy (Communication, Sales & customer, etc.) down to three (Work/Developer/Research) leaves several native plugins (huggingface, vercel, render, browserbase, openrouter, zoom, slack, hubspot) with no
category, so they only ever show under "All" and never under any category chip. That may be intentional scope for this pass, but worth confirming it's not silently hiding filterable items users expect to find by category. - Single commit mixes tests and implementation together; AGENTS.md's convention is tests-first, then implementation, as separate commits — minor, but worth splitting before merge since the repo's commit-hygiene rule is explicit about this.
- The two-column grid's bottom-border CSS (
:has(...:last-child:nth-child(even))) only strips the trailing border when the last row is a full pair; an odd total leaves a single-item last row with a bottom border that the paired rows above it don't have. Cosmetic, but visible in an odd-length catalog (this one has an odd total today).
Verified
- All CI checks pass (build-test, db-suites, e2e, isolation, lint, structural, typecheck).
pluginCatalogCategorycovers all 11 current MCP preset slugs plus the native ids it maps (confirmed againstpackages/connections/src/mcp-presets.ts).- Catch clause in
useMcpPresetCatalog's preset-load failure now reports throughreportError(packages/plugins-ui/src/mcp-preset-cards.tsx), consistent with the error-sink rule. - Manage/Disconnect and Connect verb usage matches DESIGN.md's Copy rule (one honest verb per state, accessible name carried via visible text +
sr-onlyspan rather than a stalearia-label).
Flagging as before-ready-for-review since this is still a draft.
pratikbuilds
force-pushed
the
cl-7291-redesign-plugins-gallery
branch
from
September 3, 2026 07:58
a1895dd to
1de00fc
Compare
pratikbuilds
force-pushed
the
cl-7291-redesign-plugins-gallery
branch
from
September 3, 2026 08:20
1de00fc to
413688c
Compare
Contributor
Author
pratikbuilds
marked this pull request as ready for review
September 4, 2026 14:11
pratikbuilds
marked this pull request as draft
September 4, 2026 16:23
Contributor
Author
pratikbuilds
marked this pull request as ready for review
September 6, 2026 07:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Verification
bun run checkbun install --frozen-lockfileCloses #544
Fixes CL-7291