Repository navigation
Keep composer actions aligned while stopping (CL-7293) - #570
Merged
TheGreatAxios merged 6 commits intoSep 4, 2026
Merged
TheGreatAxios merged 6 commits into
TheGreatAxios merged 6 commits into
Conversation
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Groups Stop and Send under a single grid cell so the 3-column .chat-composer-actions grid doesn't misalign when a 4th child (Stop) appears during a running turn — clean, targeted fix with a plausible root-cause story matching the bug it closes (#542).
Must fix
None.
Consider
packages/chat-ui/src/composer.tsx:aria-label/titlefor the Send button still branch only onsending(sending ? composerSending : composerSend), unchanged by this PR but now visually adjacent to Stop in the same group — worth double-checking that a screen reader user gets a clear enough label distinguishing "Send" from "Stop" when both render side by side (both are icon-only buttons).packages/chat-ui/src/styles.css:.chat-composer-submit-actionsgap (0.25rem) is a new ad-hoc value; it's consistent with the file's existing convention of literal rem values (no spacing custom properties exist in this file), so not a blocker, but flagging in case a token system is introduced later.
Verified
gap: 0.25remand other literal rem spacing values match the existing convention throughoutstyles.css(no CSS custom-property spacing tokens are used anywhere in this file) — not a DESIGN.md violation.- Both buttons still use the shared
Buttoncomponent and@corbits/iconsicons from@corbits/react-ui— no duplicated primitive. - The wrapping
<div className="chat-composer-submit-actions">correctly reduces.chat-composer-actionsback to exactly 3 direct children (attach, keyboard hint, submit-actions), matching the grid's1fr auto 1frtemplate regardless of whether Stop is rendered — this is the actual fix for the alignment bug. - New tests (
keeps Stop and Send together...,keeps queued sends available while Stop is visible) exercise the DOM structure and the queued-send behavior directly rather than just re-asserting old expectations; CI (build-test, e2e, isolation, lint, structural, typecheck, db-suites) is all green.
Contributor
Author
|
Reviewed all feedback on this PR.
The review had no must-fix items. Verification: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps Stop and Send in one right-aligned action group while a turn is running.
Send remains available for a queued follow-up while Stop cancels the active turn.
Verification
bun run checkFixes #542
Fixes CL-7293