Repository navigation
Stop importing hub-client root just for makeErrorEnvelope - #567
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
Move makeErrorEnvelope, ErrorEnvelopeShape, ErrorEnvelope, and parseErrorEnvelope into @corbits/error-sink (which already owns generateRefId and the error-envelope check). hub-client/src/error-envelope now re-exports from error-sink for backward compatibility only. Route packages that imported hub-client root solely for makeErrorEnvelope now depend on @corbits/error-sink instead, breaking the hub-client ↔ inference-catalog strongly-connected component and restoring those packages to the project-references graph. Updated packages: access-policy, agent-directory, agent-workflow-authoring, artifacts-hub, bench, chat, commands, evals, inference-catalog, insights, memory-hub, onboarding, preferences, presence, routines, run-key-history, run-scope, sidecar-placement, skills, webhook-triggers, workflow-catalog. Also updated the error-envelope structural check to validate against the new import pattern, and regenerated tsconfig references. CL-7299
TheGreatAxios
commented
Sep 3, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
This PR is obsolete. Since it was opened, main deleted packages/hub-client entirely and moved makeErrorEnvelope/parseErrorEnvelope/ErrorEnvelopeShape into @corbits/error-sink (#582–#585, merged at bac3074) — the exact end state this PR was trying to reach.
git merge-tree between the merge-base, main, and this branch produces 35 conflict markers, and the branch diff still references @workbench/hub-client (package.json deps, tsconfig references, route imports) which no longer exists on main. It won't apply cleanly as-is.
Recommend closing this PR rather than rebasing — the goal is already achieved on main, and rebasing here would mean re-deriving the same changes against a package that's gone.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
makeErrorEnvelopeand related error-envelope utilities from@workbench/hub-clientinto@corbits/error-sink(which already ownsgenerateRefIdand the error-envelope structural check). This breaks thehub-client ↔ inference-catalogstrongly-connected component created by CL-7285.What Changed
packages/error-sink/src/error-envelope.ts— canonical home formakeErrorEnvelope,ErrorEnvelopeShape,ErrorEnvelope,parseErrorEnvelopehub-client/src/error-envelope.tsre-exports from@corbits/error-sinkso existinghub-clientconsumers are unbrokenmakeErrorEnvelopefrom@corbits/error-sinkinstead of@workbench/hub-clientroot, and theirpackage.jsondeps reflect the changeVerification
bun run check— typecheck, lint, structural checks all passscripts/db-setup.test.ts(Postgres auth) is unrelatedmakeErrorEnvelopeimports from@workbench/hub-clientRelated