Isolate freshness-check fixtures from operator git hooks - #535
Merged
TheGreatAxios merged 4 commits intoAug 31, 2026
Merged
TheGreatAxios merged 4 commits into
TheGreatAxios merged 4 commits into
Conversation
Scratch repos still need git history so freshness can compare src/ to the version-introducing commit, but git commit ran the operator core.hooksPath and failed a global author allow-list. Fixtures now write history with commit-tree under a test-owned git config, and a regression plants a rejecting commit-msg hook to keep that isolation.
The regression planted a rejecting commit-msg hook but then wrote fixture history through git() env that never included that hook. Pass the hostile env into committedPackage so the writer is actually under the hook when it succeeds.
TheGreatAxios
force-pushed
the
cl-7282-a-global-git-hook-makes-the-full-local-test-suite-unpassable
branch
from
August 31, 2026 05:34
0c7c36e to
93906c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/tool-registry-publishfreshness fixtures comparedsrc/against real git history by runninggit commitin throwaway repos. That inherited the operatorcore.hooksPath, so a global commit-author allow-list made the local suite unpassable.Fixture history is now written with
git commit-treeunder a test-owned config (GIT_CONFIG_NOSYSTEM, a scratchGIT_CONFIG_GLOBAL, and-c core.hooksPath=). A regression plants a rejectingcommit-msghook and still writes the fixture.Test plan
HUB_DATA_DIR=$(mktemp -d) bun test packages/tool-registry-publish(62 pass)git commitfails the planted allow-list hook;committedPackagestill succeeds~/.config/git/hooksincludes the author allow-list