Skip to content

Document the workflow-deploy-source / workflow_run_launch_spec overlap - #526

Closed
TheGreatAxios wants to merge 2 commits into
mainfrom
cl-7271-deploy-source-launch-spec
Closed

TheGreatAxios wants to merge 2 commits into
mainfrom
cl-7271-deploy-source-launch-spec

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

CL-7271.

Analysis lane. The ticket's premise — that @corbits/workflow-deploy-source duplicates Interchange's workflow_run_launch_spec and can be deleted — does not survive reading the native writer.

The two tables share a key and several columns but encode opposite recovery models:

  • Native freezes. frozen_approval_bundle replays the approval verbatim, no re-probe. Written only by prepareExclusiveDeployment, read only by deployReadyAllocation, both in workflow-allocation-service.ts. Exclusive-only because it exists to survive an allocation being replaced.
  • Ours re-resolves. Records where the bytes came from and re-derives against the live catalog at redeploy.

That trade-off is the one CL-6687 (rotated keys never reaching live agents) was fixed in favour of re-resolution, and the one restoreDeploymentFromRecord decides the same way via "deferred-to-wake" (CL-6648). Adopting native wholesale would reverse both.

Recommends keeping both with a documented split, rather than deleting ~350 loc that turns out not to be redundant.

Two original observations survive: the missing FK on anchor_run_id (belongs to CL-7258), and the four columns with no native counterpart (entry, pin, definition_asset_id, source_ref).

Docs only. No code change. Draft — not for merge.

@TheGreatAxios
TheGreatAxios force-pushed the cl-7271-deploy-source-launch-spec branch from 4161002 to 97ac6cd Compare August 31, 2026 03:12
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review August 31, 2026 03:12
@TheGreatAxios
TheGreatAxios force-pushed the cl-7271-deploy-source-launch-spec branch from 97ac6cd to 89aaab0 Compare August 31, 2026 03:17
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Consolidated into #531 — four independent docs files merging as one CI cycle rather than four serialized ones under strict branch protection. Content unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant