Document the workflow-deploy-source / workflow_run_launch_spec overlap - #526
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
TheGreatAxios
force-pushed
the
cl-7271-deploy-source-launch-spec
branch
from
August 31, 2026 03:12
4161002 to
97ac6cd
Compare
TheGreatAxios
marked this pull request as ready for review
August 31, 2026 03:12
TheGreatAxios
force-pushed
the
cl-7271-deploy-source-launch-spec
branch
from
August 31, 2026 03:17
97ac6cd to
89aaab0
Compare
Contributor
Author
|
Consolidated into #531 — four independent docs files merging as one CI cycle rather than four serialized ones under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CL-7271.
Analysis lane. The ticket's premise — that
@corbits/workflow-deploy-sourceduplicates Interchange'sworkflow_run_launch_specand can be deleted — does not survive reading the native writer.The two tables share a key and several columns but encode opposite recovery models:
frozen_approval_bundlereplays the approval verbatim, no re-probe. Written only byprepareExclusiveDeployment, read only bydeployReadyAllocation, both inworkflow-allocation-service.ts. Exclusive-only because it exists to survive an allocation being replaced.That trade-off is the one CL-6687 (rotated keys never reaching live agents) was fixed in favour of re-resolution, and the one
restoreDeploymentFromRecorddecides the same way via"deferred-to-wake"(CL-6648). Adopting native wholesale would reverse both.Recommends keeping both with a documented split, rather than deleting ~350 loc that turns out not to be redundant.
Two original observations survive: the missing FK on
anchor_run_id(belongs to CL-7258), and the four columns with no native counterpart (entry,pin,definition_asset_id,source_ref).Docs only. No code change. Draft — not for merge.