Document workflow_definition access against the native store - #525
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
TheGreatAxios
force-pushed
the
cl-7275-workflow-definition-store
branch
2 times, most recently
from
August 31, 2026 03:12
fa2d409 to
b83b8ec
Compare
TheGreatAxios
marked this pull request as ready for review
August 31, 2026 03:12
TheGreatAxios
force-pushed
the
cl-7275-workflow-definition-store
branch
from
August 31, 2026 03:19
b83b8ec to
ddcaed8
Compare
Contributor
Author
|
Consolidated into #531 — four independent docs files merging as one CI cycle rather than four serialized ones under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CL-7275:
workflow_definitionis hand-queried 41 times because the shippedcreateWorkflowDefinitionStoreonly covers the(assetId, wireHash)selector plus the two frozen-version reads. This lane does the first two
checkboxes of that ticket, not the full 41-site migration:
Enumerated and categorized the 41 direct drizzle queries against
workflowDefinition/workflowDefinitionVersionacross 14 non-test filesin
apps/andpackages/:(definitionId, tenantId)lookup(name, tenantId[, status])lookupdescription/statusWidened
createWorkflowDefinitionStore(vendor/intx/db/src/workflow-definition-store.ts)with
findById,findByName,listByTenant,listByAsset, andupdateFields— the five shapes above, all tenant-scoped. Extended thevendor/intx/dbrow inVENDORED.mdand itsVENDORED-FROMdelta noterather than adding a new ledger row, and updated the tree-hash kill-date
record accordingly.
Migrated one representative caller per category to prove the surface
works, with tests (DB-gated where the existing suite already was; fake-db
fixtures updated to full row shapes where the store's row-validation now
runs on them):
workflow-capability-routes.ts's self-capability routevisible-definitions.ts's ancestor-chain listingresolve-myra-definition-id.ts(new DB-gated suite)agent-workflow.ts's duplicate-handle recovery checkroutes.ts'sPUT /:definitionId/statusrouteThe remaining ~36 call sites are unchanged; migrating them all is out of
scope for this lane per the ticket's own sequencing.
Test plan
bun run typecheckinvendor/intx/dbandpackages/agent-directorybun testinvendor/intx/db(new DB-gated suite, real Postgres)bun testinpackages/agent-directory(193 tests, all green)bun run check:killdatesWORKBENCH_CHECK_SINCE=origin/main bun run check(narrowed) — greenaside from two pre-existing failures unrelated to this change
(
@corbits/tool-registry-publish's freshness-check test hitting alocal git-hook author-allowlist, and a flaky
@corbits/chatrun underheavy concurrent load — both green in isolation)