Parse inline Ollama tool JSON into tool calls - #470
Merged
TheGreatAxios merged 2 commits intoAug 30, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Ollama/qwen-like models emit declared tool calls as JSON in content. The OpenAI-compatible parser only reads native tool_calls, so the director stopped with visible JSON instead of running the tool.
TheGreatAxios
commented
Aug 30, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
critique · no blockers
Reviewed the CL-7186 adapter-layer fix against the live failure where Ollama returned visible {"name":"memory_search","parameters":{"query":"this person"}} text.
No blocking correctness findings.
Evidence:
- Declared inline tool JSON is converted into structured
inference.tool_call.start+inference.tool_call.deltaevents on both streaming and JSON response paths. - Start and delta now share the same synthetic call id, so the harness can attach arguments correctly.
- Salvage is gated on tools declared for the request; unknown names, no-tools requests, extra-key JSON, arrays, mixed prose, and fenced JSON stay text.
- Prompt hardening tells Myra to invoke tools only through tool calls and not to memory_search bare greetings.
- Targeted adapter and assistant tests pass; package typecheck passes.
Local full bun run check is blocked here by unrelated local git-hook/database test issues; PR CI should be authoritative before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: CL-7186
Live symptom: Ollama Myra replies with raw memory_search JSON instead of executing the tool.
This change parses inline Ollama tool JSON into tool calls. Targeted tests cover the parser path.
Critic reviewed with no blockers.
Full local check was blocked by an unrelated local git-hook/db env issue; targeted gates pass.