Skip to content

Restore process env after memory-mount tests #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 2 commits into from
Aug 29, 2026
Merged

Restore process env after memory-mount tests #465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6086c4
Add tests for memory-mount process env restore
TheGreatAxios Aug 29, 2026
1052f15
Restore process env after memory-mount tests
TheGreatAxios Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions apps/hub/src/memory-mount.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,16 @@ const KEYS = [

type EnvKey = (typeof KEYS)[number];

const saved: Partial<Record<EnvKey, string | undefined>> = {};
const originals: Record<EnvKey, string | undefined> = {
DATABASE_URL: process.env["DATABASE_URL"],
EMBED_BASE_URL: process.env["EMBED_BASE_URL"],
EMBED_MODEL: process.env["EMBED_MODEL"],
EMBED_API_STYLE: process.env["EMBED_API_STYLE"],
EMBED_API_KEY: process.env["EMBED_API_KEY"],
RERANK_BASE_URL: process.env["RERANK_BASE_URL"],
RERANK_MODEL: process.env["RERANK_MODEL"],
OLLAMA_BASE_URL: process.env["OLLAMA_BASE_URL"],
};

function clearEnvKey(key: EnvKey): void {
// Must actually remove the key: `process.env[key] = undefined` stores the
Expand All @@ -32,18 +41,18 @@ function clearEnvKey(key: EnvKey): void {
Reflect.deleteProperty(process.env, key);
}

afterEach(() => {
function restoreOriginalEnv(): void {
for (const key of KEYS) {
const value = saved[key];
const value = originals[key];
if (value === undefined) clearEnvKey(key);
else process.env[key] = value;
saved[key] = undefined;
}
});
}

afterEach(restoreOriginalEnv);

function stashEnv(): void {
for (const key of KEYS) {
saved[key] = process.env[key];
clearEnvKey(key);
}
}
Expand Down Expand Up @@ -99,6 +108,12 @@ describe("resolveMemoryEmbed", () => {
source: "OLLAMA_BASE_URL",
});
});

test("afterEach restores KEYS after a non-stash resolveMemoryEmbed test", () => {
for (const key of KEYS) {
expect(process.env[key]).toBe(originals[key]);
}
});
});

describe("applyResolvedEmbedToProcessEnv", () => {
Expand Down
Loading