Vendor the @intx leaf packages the re-pin compiles against at a8bc06ae - #456
Merged
Merged
Conversation
…ind it Upstream added 0085_add_approval_run_idx (indexed approvalStore.listByRunId, which the re-pinned hub-api needs), taking the number our wire_projection migration held. Ours move to 0086/0087 with their original journal `when` values, which still sort after upstream's entry. The wire_projection column + loadFrozenWireProjection reader and the workflow_definition.origin column re-apply unchanged; upstream still has neither. Workbench applies the platform SQL by sorted filename through scripts/db-setup.ts, which replays from scratch and refuses a schema set up under a different file list. Tests pin both halves: a fresh replay lands upstream's index and both workbench columns, and a schema migrated under the old numbering is refused with the reset instruction rather than patched. A journal test keeps drizzle-kit's view consistent with the files.
TheGreatAxios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pin wave 2, PR 2/7 —
@intx/dbata8bc06ae.Changed: re-vendored; upstream's
0085_add_approval_run_idx(7c7916f8,approvalStore.listByRunId) takes our slot, sowire_projection→0086andorigin→0087(original journalwhens kept).Kept:
wire_projectioncolumn +loadFrozenWireProjection(CL-6324),workflow_definition.origin(CL-6452) — upstream still has neither.Retired: nothing.
Tests: fresh replay lands upstream's index and both columns (
vendor/intx/db/src/migrate.test.ts, DB-gated); a schema migrated under the old numbering is refused with the reset instruction (scripts/db-setup.test.ts) — workbench replays platform SQL from scratch by filename and never consumes the drizzle journal at runtime; journal↔files parity test.Not done: nothing deferred.