People section: report mutation failures via reportError - #444
Merged
TheGreatAxios merged 3 commits intoAug 29, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
A failing suspend mutation should call reportError with the action's operation and tenant id, not just set the generic message. Covers this before people-section.tsx wires reportError in.
Invite, cancel-invite, suspend/reactivate, remove, and role-change catches silently discarded the cause and never gave support a refId to trace. Route each through reportError with its operation and tenant id before setting the existing user-facing message. Fixes CL-7139.
The prior test only covered the suspend catch. Parametrize it over invite, cancel-invite, remove, and role-change too, each asserting its own settings.people.<action> operation.
TheGreatAxios
force-pushed
the
cl-7139-settings-people-section-mutation-catches-discard-the-cause
branch
from
August 29, 2026 04:58
d1e172c to
f215a6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CL-7139 — https://linear.app/abklabs/issue/CL-7139
Problem
packages/settings-ui/src/people-section.tsx's mutation catches (invite,cancel-invite, suspend/reactivate, remove, role-change — originally around
lines 174, 183, 194, 202, 235) all did
.catch(() => setXError(GENERIC)),discarding the
causeentirely. NoreportErrorcall anywhere inpackages/settings-ui/src— a failed mutation left nothing for support totrace back to.
Change
reportError(cause, { operation: "settings.people.<action>", tenantId })before setting the existinguser-facing message (copy unchanged):
settings.people.invitesettings.people.cancelInvitesettings.people.updateStatus(suspend/reactivate)settings.people.removesettings.people.changeRole@corbits/error-sink(workspace:*) topackages/settings-ui/package.json.Tests
Added a red/green case in
packages/settings-ui/test/people-section.test.tsx:mocks
@corbits/error-sinkviamock.module, forces the suspend mutation'sfetch to fail, and asserts
reportErrorwas called withoperation: "settings.people.updateStatus"andtenantId: "tnt_1". Verifiedit fails without the fix and passes with it.
The other settings sections (bench, chats & channels, account) have the same
gap — left for a follow-up ticket, not filed here.