Report launch-path failures through reportError - #443
Merged
TheGreatAxios merged 3 commits intoAug 29, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
TheGreatAxios
force-pushed
the
cl-7136-launch-path-failures-in-webhook-triggers-and-workflow-deploy
branch
from
August 28, 2026 12:42
b1269bb to
708ca2d
Compare
Red first: both fail against the current log-only paths, proving the gap before the fix lands.
The webhook-trigger delivery-retry exhaustion and the deploy-source recording failure were both log-only calls with no refId or tenant/run context -- the exact gap @corbits/error-sink exists to close. Route both through reportError instead. Fixes CL-7136.
TheGreatAxios
force-pushed
the
cl-7136-launch-path-failures-in-webhook-triggers-and-workflow-deploy
branch
from
August 29, 2026 05:01
252ffde to
0b3566c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CL-7136 — https://linear.app/abklabs/issue/CL-7136
Problem
Two "don't fail the caller, don't lose the signal" paths only wrote a log line, with no refId or tenant/run context:
packages/webhook-triggers/src/launch.ts:152-169— the input message failed to deliver after every retrypackages/workflow-deploy-source/src/record-on-deploy.ts:77-88(recordOrLog) — the deploy-source record write failedChange
reportErrorfrom@corbits/error-sinkwithoperation,tenantId, and anextrapayload naming the run (instanceId/triggerId/attemptsfor the webhook case,anchorRunIdfor the deploy-source case); the webhook case also passesagentId(the run'striggerAddress).log.errorcalls and their now-unused@intx/logimports; renamedrecordOrLogtorecordOrReportto match.@corbits/error-sinkas aworkspace:*dependency of both packages.Tests
packages/webhook-triggers/test/launch.test.ts: new cases assertreportErrorfires with the run's context on exhausted delivery, and doesn't fire on success. Verified red (failing against pre-changesrc) before the implementation, green after.packages/workflow-deploy-source/test/record-on-deploy.test.ts: same red/green pattern for a recording failure.Notes
cl-6687-rotated-api-keys-never-reach-live-agents) also touchespackages/webhook-triggers/src/launch.ts(adds arecordLaunchSourcescall after launch). This PR's diff is confined to the delivery-failure block so the two should rebase cleanly.bun.lock's diff includes a few unrelated lines (a@corbits/memorygithub-ref resolution swap) that reappear on any freshbun installin this repo right now, independent of this change — kept rather than hand-edited.bun run check; ran focused gates instead: packagetsc --noEmit,bun testfor both packages,prettier/eslinton changed files,check:browser-safe-subpaths, andcheck:no-product-tenancy. CI is the full gate.