Run every scripts/*.test.ts in the test gate - #433
Merged
TheGreatAxios merged 3 commits intoAug 29, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
The root test script only ran scripts/run-all.test.ts by name, so scripts/affected.test.ts, dev.test.ts, reset.test.ts, and setup-memory.test.ts (33 tests) never ran locally or in CI. Widen the bun test invocation to the shell-expanded scripts/*.test.ts glob, which picks up exactly the five top-level suites and does not recurse into scripts/e2e or scripts/checks/test (those keep their own jobs). Fixes CL-7122.
TheGreatAxios
force-pushed
the
cl-7122-scriptsaffected-dev-reset-setup-memory-tests-never-run-in
branch
from
August 29, 2026 04:46
f59d3c7 to
e0617e4
Compare
TheGreatAxios
commented
Aug 29, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
critique · request-changes
The scripts/*.test.ts glob wires scripts/db-setup.test.ts into build-test, which has no Postgres.
- package.json:20 x scripts/db-setup.test.ts:23 — bun still runs the describe callback under describe.skip, so dbTargetFromUrl("") throws DATABASE_URL is not a parseable URL.
- scripts/e2e/db-setup.test.ts:36-46 already returns before constructing a URL; this file does not.
build-test job 33234630138 is this PR. Fix the skip path (or list the five unit-safe files) before merge.
GitHub will not accept request-changes on the author's own PR; this comment is the review.
…ed-dev-reset-setup-memory-tests-never-run-in
bun still runs the describe callback under describe.skip, so dbTargetFromUrl at describe scope crashed build-test when the glob wired this file in. Parse and connect inside the test instead.
TheGreatAxios
commented
Aug 29, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
critique · comment
Skip path is fixed. dbTargetFromUrl and loadPostgres run only inside the test body, so bun still collecting under describe.skip no longer parses an empty DATABASE_URL.
- scripts/db-setup.test.ts:19-47 — describe callback only registers the test
- scripts/db-setup.test.ts:39-41 — reset-refusal assertion unchanged
build-test should go green on this head. Merge only after every check is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CL-7122 — https://linear.app/abklabs/issue/CL-7122
Problem
Root
package.json'stestscript hand-listedbun test scripts/run-all.test.ts(package.json:20), andrun-all.ts testonly discovers workspace packages underapps/*,packages/*,tools/*,workflows/*,vendor/intx/*(scripts/run-all.ts:33-39).scripts/affected.test.ts,scripts/dev.test.ts,scripts/reset.test.ts, andscripts/setup-memory.test.ts(33 tests total) live at the top level ofscripts/and were never wired into either path, so they never ran locally or in CI.Change
testscript frombun test scripts/run-all.test.tstobun test ./scripts/*.test.ts(package.json:20). The shell expands this glob beforebun testsees it, so it resolves to exactly the five top-level suites and does not recurse intoscripts/e2e/**orscripts/checks/test/**, which keep their own dedicated CI jobs.This is wiring only — no test logic changed. Files now covered by
bun run testthat weren't before:scripts/affected.test.tsscripts/dev.test.tsscripts/reset.test.tsscripts/setup-memory.test.ts(
scripts/run-all.test.tswas already covered.)Tests
Ran
bun test ./scripts/*.test.tsdirectly — 46 pass across the 5 files (13 from run-all.test.ts + 33 from the four newly-wired suites), confirming the glob picks up exactly the intended files and all previously-unrun tests are green.