CI: run database-backed package suites in walking-skeleton - #430
Merged
TheGreatAxios merged 1 commit intoAug 29, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
Contributor
Author
|
Dropped the |
TheGreatAxios
force-pushed
the
cl-7120-ci-never-runs-the-40-database-backed-package-test-suites
branch
from
August 28, 2026 18:56
041040d to
fe89754
Compare
The ~40 DB-gated test suites under packages/* and apps/hub/src gate on DATABASE_URL and skip without one. build-test (the only job running `bun run test`) has no Postgres and never sets E2E_REQUIRED, so these suites have been skipping green on every CI run despite headers claiming E2E_REQUIRED=1 turns a skip into a failure. Add a step to walking-skeleton (the job with Postgres) that runs exactly those suites with E2E_REQUIRED=1, discovering them by the same DATABASE_URL grep signal they gate on so a newly added suite is picked up automatically. This is a CI-only change; there is no unit test to write. Fixes CL-7120.
TheGreatAxios
force-pushed
the
cl-7120-ci-never-runs-the-40-database-backed-package-test-suites
branch
from
August 29, 2026 04:46
fe89754 to
d970e3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CL-7120 — https://linear.app/abklabs/issue/CL-7120
Problem
Every DB-gated suite under
packages/*andapps/hub/srcgates one2eDatabaseUrl()(scripts/e2e/harness.ts:27-38) anddescribe.skipswithout a database; their headers claim
E2E_REQUIRED=1turns thatinto a loud failure. In
.github/workflows/ci.yml,build-test(theonly job running
bun run test) has no Postgres and never setsE2E_REQUIRED;walking-skeleton(the only job with Postgres) onlyran
scripts/e2e,test/isolation, andapps/hub/test. As a result~39 test files skip green on every CI run.
Change
walking-skeleton, after the hub DB suites step, thatruns every DB-gated suite (
grep -rl DATABASE_URL --include='*.test.ts' packages apps, excludingapps/hub/testwhich already runs) withE2E_REQUIRED: "1"against the job's existing Postgres service.Discovering suites by the same
DATABASE_URLsignal they gate onmeans a newly added suite is picked up automatically, with no
hardcoded file list to maintain.
build-testis unchanged and stays the no-DB unit gate.apps/hub/src/artifacts-mount.test.tsmatches theDATABASE_URLgrep and will run in the new step, but it isn't actually DB-gated — it
mounts against a
stubEngine, not a live Postgres connection. It'sharmless to include (no real DB dependency to fail on) and excluding
it would need a special case, so it's left in.
write beyond exercising the existing suites against a real database.
Tests
Ran the exact suites the new step will run, locally against Postgres:
The existing
walking-skeletonjob runs in ~4.5 minutes; the addedstep adds well under a minute, staying inside the job's 20-minute
timeout.