Skip to content

Hop Agents roster peek to full agent page - #399

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-6875-agents-roster-opens-a-twin-detail-panel-with-no-hop-to-the
Aug 24, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-6875-agents-roster-opens-a-twin-detail-panel-with-no-hop-to-the

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • Agents roster detail panel gains an Open CTA that hops to /agents/<slug> via detailPath.
  • Keeps the panel as DESIGN quick-peek; does not twin the full agent page.

Closes CL-6875

Test plan

  • Unit: selected definition panel offers hop to /agents/<slug>
  • Manual: select agent on roster → Open → lands on agent page

CL-6875: AgentDetailPanel Open CTA uses detailPath to /agents/<slug>
so the roster panel stays a quick-peek, not a twin of the agent page.
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Fix before merge: Open on the Agents roster uses the display name as the detail-route identity (detailPath(definition.name)). Agent detail paths are keyed by definition id/slug, not a mutable display name. An agent whose name differs from its path id will Open to the wrong or missing page. Use the definition path identity instead.

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Prior FIX-FIRST on this PR was a false positive: definition.name is the immutable kebab slug, not displayName. Opening via detailPath({ slug: definition.name, id: definition.id }) is correct; swapping to id would recreate CL-6875 because isValidSlug("wfd_*") is false.

@TheGreatAxios
TheGreatAxios merged commit 3c4f0d3 into main Aug 24, 2026
5 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-6875-agents-roster-opens-a-twin-detail-panel-with-no-hop-to-the branch August 24, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant