CL-6843: Remove draft-only Notifications section from settings registry - #356
Merged
TheGreatAxios merged 3 commits intoAug 23, 2026
Merged
Conversation
Honest absence over fake toggles — same pattern as AgentSection. No per-user preference store backs personal notification prefs yet; keep the dormant component for re-add when one exists. Workbench-scoped mute/mentions in chat-ui are unchanged.
…e-notifications-draft-only-ui # Conflicts: # packages/settings-ui/README.md # packages/settings-ui/src/section-registry.tsx
TheGreatAxios
deleted the
cl-6843-wire-or-remove-notifications-draft-only-ui
branch
August 25, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat) section from@corbits/settings-ui's settings registry — draft-only toggles with an honesty toast on Save, same treatment as AgentSection.notifications-section.tsxas a dormant draft with a re-add condition once a per-user preference store exists. Drops the package export so nothing can mount the fake UI.@corbits/chat-uiare unchanged (those already persist).Test plan
bun test test/section-registry.test.tsxinpackages/settings-uiCL-6843