CL-6841: Delete dead AgentSection and CredentialsSection - #355
Merged
TheGreatAxios merged 1 commit intoAug 23, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
Neither section is registered or called. Connections owns key management; agent prefs have no hub store. Drop the files, exports, orphaned agent* strings (keep timezone copy used by Account), and credentials-only strings.
TheGreatAxios
deleted the
cl-6841-delete-dead-agentsection-and-credentialssection-from
branch
August 25, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentSection(never exported / not in the settings registry) and its orphanedSETTINGS_STRINGS.agent*copy. KeepagentTimezoneLabel/agentTimezoneAutoDetectused by Account.CredentialsSection/CredentialsTable/CreateCredentialDialog(Connections already owns key management) plus credentials-only strings; keepcredentialRevokedToastfor Connections.Test plan
bun run --filter @corbits/settings-ui typecheckbun run --filter @corbits/settings-ui test(140 pass)Closes CL-6841