CL-6735: Sanitize sidebar/bench preview away from credential-error paragraphs - #350
Merged
TheGreatAxios merged 2 commits intoAug 23, 2026
Conversation
Sidebar/bench activity must never preview credential-error paragraphs, HTTP status, or raw provider dumps — prefer last good text, else the short consumer notice.
previewOf and listActivity collapse classified inference failures and turnFailed notices to the short consumer sentence, and walk recent messages for the last good human/agent text when the newest is a failure.
TheGreatAxios
deleted the
cl-6735-sidebar-preview-shows-the-credential-error-paragraph
branch
August 25, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
previewno longer shows credential-error paragraphs, HTTP status marks, or raw provider dumps.listActivityprefers the last good human/agent text; otherwise it falls back to the short consumer notice.packages/chat/src/room-messages.test.ts.Closes CL-6735
Test plan
bun test packages/chat/src/room-messages.test.ts packages/chat/src/consumer-inference-text.test.tsbunx tsc -p packages/chat --noEmitNotes
activityPreviewText/isClassifiedInferenceFailureTextinconsumer-inference-text.ts, wired throughpreviewOf+activityPreviewFromNewestFirstinroom-messages.ts.