CL-6772: keep join and system notices on the left edge - #349
Merged
TheGreatAxios merged 3 commits intoAug 23, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
TheGreatAxios
deleted the
cl-6772-system-join-rows-appear-on-the-wrong-message-edge
branch
August 25, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-own="true", even when the viewing user caused them..chat-event-lineleft-aligns under the message gutter instead of centering.Closes CL-6772
Test plan
bun test test/own-message-alignment.test.tsx test/system-join-edge.test.tsx test/system-row-chrome.test.tsxinpackages/chat-uibun testinpackages/chat-ui(690 pass)bun run typecheckinpackages/chat-uiOut of scope