CL-6467: plugins list as grouped rows - #192
Merged
Merged
Conversation
…very row Grouped rows already existed per-category (CL-6272.1); this closes the gap against the new mock spec (CL-6467): the list carries its own h1 + verbatim sub copy, and a row's connection/provenance status is core information, not something dropped below the xl breakpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the gap between the Plugins list and the new mock spec (
§7.1). The list already rendered grouped, bordered rows per category (from CL-6272.1) rather than a card grid, so this is a targeted fix rather than a rewrite:h1("Plugins") and verbatim.subdirectory copy above the grouped rows.hidden … xl:blockclass hiding a row's status caption ("Connected · Connected here" / "Needs attention · Inherited" / "Not connected") below thexlbreakpoint — per spec this is a core column, not overflow.Detail page (
§7.2, novel surface) is explicitly out of scope for this unit — a separate ticket/unit builds it, soManage/Connectstill open the existing connect panel rather than navigating to a route that doesn't exist yet.What I did not verify
Communication,Productivity, …) against the mock's example categories ("Project & issue tracking","Messaging") — the mock only shows 4 illustrative plugins under 2 groups; recategorizing the real ~18-connector taxonomy felt like a separate product decision, not a layout change, so I leftPLUGIN_CATEGORY_ORDER/CATEGORY_BY_IDuntouched.PluginLogo's tile styling (currently a bordered neutral square, not the mock's colored-brand-tile-with-initials pattern) — that's an icon/branding system change, not list-layout.bun testinpackages/plugins-uiandapps/web/test/plugins-page.test.tsx,tsc --noEmitinpackages/plugins-ui, andbun run buildinapps/web— did not run the full-repobun run check.Test plan
bun testinpackages/plugins-ui(12 pass, including 3 new tests: heading/sub copy, status caption never hidden, empty directory)bun test test/plugins-page.test.tsxinapps/web(5 pass, unchanged)tsc --noEmitinpackages/plugins-ui(clean)bun run buildinapps/web(succeeds)bun run check(not run — scoped only per instructions)Refs CL-6467 (does not close it).