CL-6462: Land in Myra's room as soon as she is live - #188
Merged
Merged
Conversation
Pins the deploy order the background drain uses (setup agent first), the provisioning status flag a waiting surface branches on, the warm loader with no counts, the land that happens without waiting on the rest of the seeds, the stall affordance, and the quiet post-landing line.
…ishes Deploy order is now a product decision: the setup agent leads DEFAULT_WORKFLOWS, so a fresh signup can start talking in seconds while the digest, recurring-task and research seeds converge behind them. The provisioning status route answers the question a waiting surface actually has — setupAgentReady — instead of handing out a count of seed workflows. The land hop retries the launch itself every few seconds and goes the moment Myra answers, showing the shared warm loader (headline plus rotating tips) and nothing else while it waits; a wait that runs long says so plainly and offers another go. Anything still deploying after landing is one quiet dismissible line in the shell, shown only to someone who just connected a provider. The blank screen underneath it all was WorkbenchLoadingState: a loader already mounted with a delay never became visible when its delay dropped to zero, so the post-connect wait rendered as an empty page with a bare progress fragment on it.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-connect step rendered a bare centred "0 of 5 ready" on an empty page. The fix is structural, not copy.
Prioritize the first agent. The setup agent (Myra) now leads
DEFAULT_WORKFLOWS, so the background drain deploys her before the digest, recurring-task and research seeds.seedTenantworks the list in order at ~20s each, so the order is what a fresh signup experiences.Land on launchability, not completion. The
/land hop retries the launch itself every few seconds and goes the moment Myra answers — the remaining seeds converge invisibly.GET /api/onboarding/provisioning-statusgainedsetupAgentReady, the only field a waiting surface should branch on;deployed/pendingstay for operators.Warm loader, no counts. The wait is
WorkbenchLoadingState— headline plus rotating tips — and nothing else. No screen shows an internal count.Stall affordance. A wait past 45s says "Myra is taking longer than usual" with a Try again, instead of a frozen number.
After landing, anything still deploying is one quiet dismissible line in the shell, shown only to someone who just connected a provider — never a blocking screen.
Root cause of the blank page:
WorkbenchLoadingStatenever became visible when an already-mounted loader'sdelayMsdropped to 0 — exactly the transition this route makes — so the loader vanished and left only the bare progress fragment on an empty page.Fixes CL-6462