fix(web): one worker-to-bench mapping shared by the sidebar, roster, worker page, and Members (CL-9604) - #1026
Merged
Merged
Conversation
…worker page, and Members (CL-9604)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
useWorkerBenches()(apps/web/src/worker-benches.ts) maps each workspace worker to the benches running a copy of it.A bench deploys its own copy with a new asset id but the same deploy-source asset name, so the join is by asset name, not display name.
Replaces the first-bench logic on the roster and worker page, the name match in the sidebar worker row, and the Members agent links (which used bench asset ids that never matched a workspace worker).
Not covered: the two-bench browser first-run assertion.
Resolves CL-9604