fix(verify): reject a zero-length signing key instead of throwing - #23
Merged
Merged
Conversation
An empty standard-webhooks or Slack secret made WebCrypto throw on a zero-length HMAC key, so the hook answered 500. It now fails verification with 401. The README says an unprefixed base64 secret is tried decoded first, then raw, and that a crash between claiming a replay key and forwarding holds the key until it expires. Closes CL-9457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty
standard-webhookssecret (""orwhsec_) or an empty Slack secret made WebCrypto throw on a zero-length HMAC key, so the hook answered500instead of401.Changes
verifyStandardWebhooksskips zero-length keys andverifySlackrejects an empty secret, so both returnfalse(401).""andwhsec_under standard-webhooks, and an empty Slack secret.Checks
bun run check,bun run buildand the Node pack smoke pass locally;test:e2eneeds Postgres and runs in CI.Closes CL-9457