fix: verify raw bytes, decode Standard Webhooks secrets, cap body size - #21
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
Reject an empty bearer secret. Unprefixed Standard Webhooks secrets still verify as raw bytes, as 0.1 read them. Refs CL-9451.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9451
c.req.arrayBuffer()bytes, so a sender that signs non-UTF-8 or unnormalized bytes verifies. The verified bytes are decoded strictly as UTF-8 and forwarded unchanged; a body that is not UTF-8 gets415instead of being mangled with replacement characters, since trigger mail carries text.whsec_prefix.whsec_secrets verify exactly as before. Compatibility call-out: 0.1 used an unprefixed secret as raw bytes (and the README said so), so an unprefixed secret is tried under both the spec key and the raw key. Awhsec_secret is never used raw.verifyBearerrejects an empty secret.bodyLimitcaps the body at 1 MiB (413) before anything is read or hashed.Tests for each were added first and failed before the fix.