Skip to content

Set Node 24 floor for google-tools - #2

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-8544-set-node-24-floor-for-corbitsgoogle-tools
Sep 22, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-8544-set-node-24-floor-for-corbitsgoogle-tools

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Stacks on add-gmail-tools for CL-8544.

  • engines.node >=22 to >=24
  • CI matrix covers Node 24
  • README states the Node 24 floor
  • package.json author is Sawyer Cutler sawyer@dirtroad.dev

Verification: bun run typecheck (pass), bun test src + live unit tests 36 pass / 0 fail, npm pack --dry-run succeeds.

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Review

Verdict: approve, keep stacked on add-gmail-tools (#1). Do not retarget main until #1 lands. verify (24) green. No prior reviews.

Should-fix: after setup-node 24 every step is still bun. Unlike mailbox/artifacts, nothing executes node against dist, so the job does not prove engines.node >=24. Fine to land with #1; add a node import smoke if you want the badge to mean Node.

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Re-review

Verdict: approve. SHA 7bdccd3. Still stacked on add-gmail-tools (#1).

Node smoke imports dist/index.js and asserts createGmailTools. bun typecheck/test/build green (36 tests). Do not retarget main until #1 lands.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review · Approve

Raises the package's Node floor to 24 (engines.node, README, CI matrix) and adds a CI workflow that installs, typechecks, tests, builds, and smoke-checks the built output under Node 24.

Verified: bun install --frozen-lockfile, bun run typecheck, bun test (36 pass, 2 self-skipped live tests, 0 fail), bun run build, and the CI workflow's node -e dist-import smoke all succeed locally on Node 24.4.1 / Bun 1.4.2. npm pack --dry-run packs cleanly.

Notes

  • package.json:14 — the author field changes from Corbits to a personal name/email in the same commit as the Node-floor bump (345ca86), with no mention of it in that commit's message. The PR description calls it out, but worth a beat: is moving org-owned package attribution to a personal address intentional here?
  • 7bdccd3 subject uses a ci: prefix; every other commit in this repo's history is a plain sentence with no prefix.

Neither blocks merge.

setup-node 24 already ran, but verify/typecheck/test/build were bun-only.
Import dist/index.js with node after the build so engines.node >=24 is real.
@TheGreatAxios
TheGreatAxios force-pushed the cl-8544-set-node-24-floor-for-corbitsgoogle-tools branch from 7bdccd3 to f365bd3 Compare September 22, 2026 05:55
@TheGreatAxios
TheGreatAxios changed the base branch from add-gmail-tools to main September 22, 2026 05:55
@TheGreatAxios
TheGreatAxios merged commit 29c9879 into main Sep 22, 2026
2 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-8544-set-node-24-floor-for-corbitsgoogle-tools branch September 22, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant