Set Node 24 floor for google-tools - #2
Conversation
ReviewVerdict: approve, keep stacked on add-gmail-tools (#1). Do not retarget main until #1 lands. verify (24) green. No prior reviews. Should-fix: after setup-node 24 every step is still bun. Unlike mailbox/artifacts, nothing executes node against dist, so the job does not prove engines.node >=24. Fine to land with #1; add a node import smoke if you want the badge to mean Node. |
TheGreatAxios
left a comment
There was a problem hiding this comment.
Review · Approve
Raises the package's Node floor to 24 (engines.node, README, CI matrix) and adds a CI workflow that installs, typechecks, tests, builds, and smoke-checks the built output under Node 24.
Verified: bun install --frozen-lockfile, bun run typecheck, bun test (36 pass, 2 self-skipped live tests, 0 fail), bun run build, and the CI workflow's node -e dist-import smoke all succeed locally on Node 24.4.1 / Bun 1.4.2. npm pack --dry-run packs cleanly.
Notes
package.json:14— theauthorfield changes fromCorbitsto a personal name/email in the same commit as the Node-floor bump (345ca86), with no mention of it in that commit's message. The PR description calls it out, but worth a beat: is moving org-owned package attribution to a personal address intentional here?7bdccd3subject uses aci:prefix; every other commit in this repo's history is a plain sentence with no prefix.
Neither blocks merge.
setup-node 24 already ran, but verify/typecheck/test/build were bun-only. Import dist/index.js with node after the build so engines.node >=24 is real.
7bdccd3 to
f365bd3
Compare
Stacks on add-gmail-tools for CL-8544.
Verification: bun run typecheck (pass), bun test src + live unit tests 36 pass / 0 fail, npm pack --dry-run succeeds.