fix: cap Retry-After, reject duplicate indices, trim baseURL slash - #18
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
Resolve apiStyle before the empty-docs short-circuit so a bad style fails on every call. Refs CL-9449.
TheGreatAxios
added this pull request to stack #15
September 27, 2026 02:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9449
extractRetryAfterMsclamps to[0, 60s], so a huge seconds value or a far-future date can no longer overflow the timer and fire immediately.protocol_mismatchRerankRequestError. Chose reject over dedupe: no supported provider repeats indices, so a repeat means a broken server, and a silent max-score dedupe would hide it.apiStyleis resolved before the empty-docs short-circuit, so an unknown style throws on every call.baseURLis trimmed once inrerankDocuments, so built-in and custom adapters both get a clean root.Tests for each were added first and failed before the fix.