fix: handle response.incomplete when streaming - #23
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9424
Summary
response.incompleteevent (for examplemax_output_tokensor a content filter) used to fall through to the default case, so the turn finished as if it had succeeded.ProtocolMismatchErrorwith theincomplete_detailsreason, asparseJSONResponsedoes for statusincomplete.runInferenceturns it into aprotocol_mismatchinference.error.@intx/inference0.4's harness drops the events of aparseResponsecall that throws, ignoresinference.errorevents from adapters, and has no end-of-stream hook, so an adapter can't emit usage and fail on the same event.response.incompletethroughrunInferenceand asserts aprotocol_mismatcherror containing the reason and noinference.done.Checks
bun run check,bun run build,bun run test:e2eand the Node pack smoke pass locally.