Skip to content

refactor: merge static headers without an object spread - #17

Merged
TheGreatAxios merged 1 commit into
cl-9228-openai-responses-rewrite-readme-quickstart-to-run-one-turnfrom
openai-responses-merge-static-headers-without-spread
Sep 27, 2026
Merged

TheGreatAxios merged 1 commit into
cl-9228-openai-responses-rewrite-readme-quickstart-to-run-one-turnfrom
openai-responses-merge-static-headers-without-spread

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replaces the ...quirks.headers.static spread in buildResponsesRequest with an explicit loop.
  • Header precedence is unchanged: static headers override the defaults, and model, option and session headers override static ones. A test pins the static-over-default and model-over-static cases.
  • Stacked on docs: rewrite README around a runnable quickstart and quirks table #16.

Verification

  • bun install --frozen-lockfile, bun run build and bun run check (typecheck, lint, format, 41 pass, 2 skip) pass.

Closes CL-9359

@TheGreatAxios
TheGreatAxios force-pushed the openai-responses-merge-static-headers-without-spread branch 2 times, most recently from c716c50 to af2230a Compare September 25, 2026 17:37
@TheGreatAxios
TheGreatAxios force-pushed the openai-responses-merge-static-headers-without-spread branch 2 times, most recently from 34e2a8d to 85899c7 Compare September 25, 2026 22:48
Precedence is unchanged: static headers override the defaults, and the
model, option, and session headers override static ones. A test pins
the static-over-default and model-over-static cases.
@TheGreatAxios
TheGreatAxios force-pushed the openai-responses-merge-static-headers-without-spread branch from 85899c7 to 342ec61 Compare September 26, 2026 01:33
@TheGreatAxios TheGreatAxios changed the title Merge static headers without an object spread refactor: merge static headers without an object spread Sep 26, 2026
@TheGreatAxios
TheGreatAxios added this pull request to stack #19 September 26, 2026 01:58
@TheGreatAxios
TheGreatAxios merged commit 61221a3 into main Sep 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant