test: table-drive the request-body quirk matrix - #11
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
TheGreatAxios
commented
Sep 25, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed the full diff. Quirk table covers every boolean/verbatim quirk that shapes the body plus the accept header; deleted cases are asserted in e2e.test.ts (response.created passthrough, cache_write usage split). Edge-case usage clamps and the fully populated mapping stay since e2e does not cover them. No findings.
TheGreatAxios
force-pushed
the
cl-9254-openai-responses-trim-responsestestts-to-the-quirk-matrix
branch
from
September 25, 2026 06:01
0eaf109 to
f38c6c9
Compare
Contributor
Author
|
Independent review findings addressed and force-pushed: commit message reworded, unknown-event forward-compat test restored (not covered by e2e). check passes. |
TheGreatAxios
force-pushed
the
cl-9254-openai-responses-trim-responsestestts-to-the-quirk-matrix
branch
from
September 25, 2026 17:29
cc51a94 to
81c6c2a
Compare
TheGreatAxios
force-pushed
the
cl-9254-openai-responses-trim-responsestestts-to-the-quirk-matrix
branch
from
September 25, 2026 22:48
81c6c2a to
a9a9f1d
Compare
TheGreatAxios
changed the base branch from
main
to
cl-9256-openai-responses-add-env-gated-live-responses-api-test
September 25, 2026 22:48
This was referenced Sep 25, 2026
TheGreatAxios
changed the title
Collapse the per-quirk request-body tests into one typed table over quirk flags and expected body fields, adding store, instructions, maxOutputTokens, and temperature rows. Delete the OpenAI-shaped usage test, whose cache-write split the end-to-end suite already asserts.
TheGreatAxios
force-pushed
the
cl-9254-openai-responses-trim-responsestestts-to-the-quirk-matrix
branch
from
September 26, 2026 01:33
a9a9f1d to
1da6b65
Compare
TheGreatAxios
changed the title
TheGreatAxios
added this pull request to stack #19
September 26, 2026 01:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/e2e.test.tsalready asserts throughrunInference.Verification
bun run check(typecheck, lint, format:check, test): 39 pass, 2 skip, 0 fail.bun run buildpasses.Closes CL-9254