Address pre-publish review findings for corbits-memory - #37
Merged
TheGreatAxios merged 1 commit intoSep 21, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
Contributor
Author
ReviewVerdict: request changes. No prior reviews. CI This branch is still a pre-publish README/package.json pass against old main. Three later commits (#41 FKs, #43 sidecar, #44 team-memory) are not in it. Blocking
Not blocking: @types/bun pin latest to 1.4.2; author line is already on main. Rebase onto current main, restore sidecar install docs, and only claim npm install if the package is actually on the registry. Conflicts with #42 on README Requirements — land #42 first if both stay open. |
TheGreatAxios
force-pushed
the
cl-8195-address-pre-publish-review-findings-for-corbits-memory
branch
from
September 21, 2026 00:19
58cffaf to
27e1e8c
Compare
Contributor
Author
Re-reviewVerdict: approve. Rebased at 27e1e8c. MERGEABLE. Sidecar README survived. Install is still git (package unpublished). No npm install 404. typecheck 0, bun test 484 pass. |
TheGreatAxios
force-pushed
the
cl-8195-address-pre-publish-review-findings-for-corbits-memory
branch
from
September 21, 2026 04:22
27e1e8c to
e7d1e73
Compare
TheGreatAxios
deleted the
cl-8195-address-pre-publish-review-findings-for-corbits-memory
branch
September 21, 2026 04:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses CL-8195 pre-publish review findings.
Summary:
npm install @corbits/memory(published path; no git URL, no unpublished note).feed,forget,purge, andset-retention-classroutes with their grants, and points at the@corbits/memory/distillerand@corbits/memory/configexports.enginesfield (no dist build).@types/bunpinned fromlatestto exact1.4.2(lock updated to match).package.jsonauthor isSawyer Cutler <sawyer@dirtroad.dev>.Verification:
bun run typecheck(tsc --noEmit): pass, exit 0.bun test ./src: 481 pass, 0 fail, exit 0.npm pack --dry-run: 80 files, 136.1 kB tarball, exit 0.Fixes CL-8195