test: fold duplicate schema and SSE suites - #43
Merged
TheGreatAxios merged 3 commits intoSep 27, 2026
Conversation
TheGreatAxios
commented
Sep 25, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review: an independent review pass covered this branch, and every finding is fixed. Build, typecheck and tests pass against real Postgres.
TheGreatAxios
force-pushed
the
cl-9270-mailbox-delete-schema-ddl-parity-and-schema-check-tests
branch
from
September 25, 2026 15:02
e01cd9e to
a95b5a3
Compare
TheGreatAxios
force-pushed
the
cl-9270-mailbox-delete-schema-ddl-parity-and-schema-check-tests
branch
from
September 25, 2026 17:52
a95b5a3 to
4139e51
Compare
TheGreatAxios
force-pushed
the
cl-9270-mailbox-delete-schema-ddl-parity-and-schema-check-tests
branch
2 times, most recently
from
September 26, 2026 01:36
a671502 to
b37ba5a
Compare
TheGreatAxios
added this pull request to stack #47
September 26, 2026 01:58
The column-type rejection and the schema.ts-vs-DDL index parity are migration behavior, so they live with the migration suite. Closes CL-9270.
Subscription, heartbeat and backpressure cases were spread over three files with overlapping setup and two duplicated cases. Closes CL-9272.
TheGreatAxios
force-pushed
the
cl-9270-mailbox-delete-schema-ddl-parity-and-schema-check-tests
branch
from
September 26, 2026 02:40
b37ba5a to
2be4853
Compare
TheGreatAxios
removed this pull request from stack #47
September 26, 2026 02:40
TheGreatAxios
added this pull request to stack #50
September 26, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema-check.test.tsandschema-ddl-parity.test.tsare deleted. Their unique cases (column-type rejection, index parity) move intomigrations.test.ts; three cases it already covered are dropped.bus-unsubscribe,sse-heartbeatandsse-streamtests merge intosrc/sse.test.ts. Two duplicated cases are dropped: bus-level tenant isolation, which the route-level test covers, and the throwing-listener case, merged into the mid-set throw case.native-store.tsdoc comment says why reads use rawsql:schema-check.tsasserts the drizzle table objects at boot.Verification
CI is green on this branch: install
--frozen-lockfile, build, typecheck, tests against Postgres, and the Node consumer smoke test.Closes CL-9270
Closes CL-9272