docs(readme): Quickstart shows real host usage (CL-8775) - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveCredentialByName+CredentialCipher.decrypt) that no consumer in Workbench or@corbits/memoryactually uses; that chain was removed from Workbench upstream, and@corbits/memoryis env-only.EmbedConfig(baseURL/model/optionalapiKey) anddeps(hostfetch+createDefaultScheduler()), callingembedTexts, plusprobeEmbedDimsat startup. Where the config comes from is explicitly the host's choice — the README points at@corbits/memory'sEMBED_BASE_URL/EMBED_MODEL/EMBED_API_KEYenv vars as one real example, without claiming this package itself resolves credentials.@corbits/embeddingtoday. It now only states what's actually true: this package shares@intx/inference's transport, error taxonomy, and retry behavior with chat calls.@intx/dbdevDependency added in the previous revision — no longer needed since the fence doesn't touch DB/credential types.Test plan
bunx tsc -pagainst a scratch file with the exact Quickstart code fence (deleted before commit) — compiles cleanbun run typecheck(package's owntsc --noEmit) — passesbunx prettier -w README.md— applied