fix: repair a relative request URL instead of throwing - #20
Merged
Merged
Conversation
withCodexContentTypeRepair parsed the request URL with no base, so a relative URL such as a mediated fetch's path threw. It now resolves against a placeholder origin and only the pathname is checked. Closes CL-9457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withCodexContentTypeRepaircallednew URL()on the request URL with no base, so a relative URL (for example a mediated fetch's path) threw instead of reaching the backend.Changes
new URL(url, "http://localhost").pathname); only its path is checked, as before./backend-api/codex/responsesURL is repaired.Checks
bun run check,bun run build,bun run test:e2e(the live test skips without credentials) and the Node pack smoke pass locally.Closes CL-9457