feat: make refreshCodexTokens previous tokens optional - #13
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
TheGreatAxios
added this pull request to stack #18
September 26, 2026 04:21
TheGreatAxios
force-pushed
the
cl-9404-codex-provider-make-refreshcodextokens-previous-tokens
branch
from
September 26, 2026 04:26
d68ced1 to
7a9add4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9404
Summary
refreshCodexTokens(refreshToken, now, previous?, fetchImpl?):previousis now optional. When given, itsaccountIdis still carried forward if the refresh response has noid_token.@corbits/oauth-core/hub'sOAuthLoginProvider.refreshonly receives(refreshSecret, now), and its refresher already keeps the prior credential metadata. The README drops the fake{ access: "", refresh }tokens and passesrefresh: (refreshSecret, now) => refreshCodexTokens(refreshSecret, now).previouscall: the refresh token is kept andaccountIdstays unset.previousthe caller keeps the account id some other way, for example in credential metadata.Checks
bun run checkpasses (13 tests).