Fail closed when a named profile file is missing - #875
Merged
TheGreatAxios merged 2 commits intoSep 11, 2026
Merged
Conversation
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Comment
Missing named profile files fail closed in resolveProfile; a missing project overlay stays optional.
Findings
src/profiles.test.ts— merge test still reimplements{ ...namedProfile }and comments that home cannot be injected, while this diff addshomeand uses it in the new tests. Drive that merge throughresolveProfile(cwd, undefined, home).
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Comment
Throw after loadProfile null is the right layer. ENOENT-only null keeps JSON/schema errors distinct. Optional third home arg; loadConfig still calls the two-arg form.
Findings
- Merge test comment is now false; project-over-named merge is not actually executed via
resolveProfile.
TheGreatAxios
force-pushed
the
cl-7636-fail-closed-when-profile-names-a-missing-file
branch
6 times, most recently
from
September 11, 2026 03:25
d119733 to
9d152f9
Compare
TheGreatAxios
force-pushed
the
cl-7636-fail-closed-when-profile-names-a-missing-file
branch
from
September 11, 2026 03:26
9d152f9 to
1ac65b0
Compare
TheGreatAxios
deleted the
cl-7636-fail-closed-when-profile-names-a-missing-file
branch
September 11, 2026 03:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--profilename (or a projectprofilekey) whose file does not exist now throws, naming the missing path, instead of silently running on defaultsprofile.jsonstays silentVerification
bun test src/profiles.test.ts— 14 pass, exit 0Fixes CL-7636