refactor(workflows): extract invokeStep from settle - #1210
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing without merge: the step-runtime/workflow cutover was removed from 0.3.33 and moved to the v0.4.2 runtime tranche. The current PR is also not the runSubAgentInner → invokeStep seam described by the Linear issue, so it should not be carried forward as the implementation. No code was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the per-step dispatch block from settle into a private invokeStep method with zero behavior change.
settle keeps the loop skeleton, frame exhaustion and pop, parent advance, the undefined-step guard, and a single call site. invokeStep returns true when it lands on an executable step and false when the loop should continue; throws propagate unchanged.
Six behavior pins appended to tests/unit/workflows-runtime.test.ts. Baseline event log captured on the unmodified tree and diffed byte-identical after the extract.
Fixes CL-8289