Skip to content

Keep stored session model on resume unless flags override - #1198

Open
TheGreatAxios wants to merge 1 commit into
mainfrom
cl-8995-resume-model
Open

TheGreatAxios wants to merge 1 commit into
mainfrom
cl-8995-resume-model

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Resume restores the stored session's provider:model instead of clobbering it with the launch default
  • Explicit --provider/--model flags win, tracked as a parse-time signal rather than inferred by value comparison
  • Legacy model-less run.json records keep the launch default; malformed stored identities never throw

Verification

  • session-start + resume-seed suites pass (12 pass, 0 fail)
  • config/session/tui suites pass (2736 pass, 0 fail)
  • bun run build passes; lint clean; typecheck shows only the pre-existing vendor semver error (identical on clean tree)
  • manual spot-check: loadConfig sets modelOverride only with --model/--provider; resume restores stored-p:stored-m on picker and id branches, keeps launch default with flags or legacy records
  • Full suite: 8593 pass, 2 fail — both pre-existing/environmental (missing ts-prune binary; shell-guard timing test passes in isolation)

Fixes CL-8995

Resumed sessions lose their stored provider:model to the launch default on both resume paths. The stored identity now restores unless --provider or --model was passed; the override rides a parse-time flag, never a value comparison.
@linear-code

linear-code Bot commented Sep 28, 2026

Copy link
Copy Markdown

CL-8995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant