fix(auth): recover stale credential file locks via PID liveness - #1194
Open
TheGreatAxios wants to merge 5 commits into
Open
TheGreatAxios wants to merge 5 commits into
TheGreatAxios wants to merge 5 commits into
Conversation
The steal re-read narrows but does not close the unlink window, so a loser that deletes a winner's live lock could run two holders. Claims are now unique per waiter and re-read after create; a mismatch closes and re-contends. Steal contention also falls through to the deadline and sleep path instead of hot-spinning.
Collaborator
Author
|
Follow-up (175be0b) addresses the two review notes:
No deterministic test for the steal race: forcing one would require fault-injection hooks in the lock path for a window that is now a single-syscall race, so I kept the 4 existing takeover tests green instead (store suite 11/11, full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale Codex/xAI credential-file locks from crashed holders brick the auth store until manual removal. Tag new locks with the holder PID and take over dead-holder and aged legacy locks; live holders still wait out the existing timeout.
Verification: bun test src/auth/store.test.ts (11 pass), bun test src/auth/ (82 pass), bun run build (exit 0). Typecheck reports only the pre-existing vendor/intx-types semver error, reproduced on the pristine tree.
Fixes CL-8998