feat(mount): mint creator grants inside @corbits/artifacts - #38
Open
TheGreatAxios wants to merge 2 commits into
Open
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
Insert creator-origin grants on artifact:<id> in the creating transaction for both POST /artifacts and POST /artifacts/upload. onArtifactCreated still runs for other side effects.
The mount imports generateId from it at runtime, so a consumer must resolve it rather than rely on a hoisted transitive copy.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creator
writeandarchivegrants are now minted by the package instead of by each host'sonArtifactCreatedhook.What changed
POST /artifactsandPOST /artifacts/upload(once per file) insertcreator-origin,allowgrants onartifact:<id>for the creating principal via@intx/db'sgranttable, in the same transaction as the artifact. Inserts useonConflictDoNothing.onArtifactCreatedis still called for other side effects.grantOwnershiphook; README and AGENTS.md updated.Testing
bun run checkandbun run test:coverage(Postgres,ALLOW_DESTRUCTIVE_ARTIFACT_TESTS=1): 305 pass, 0 fail.Closes CL-9480